Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wireshark: cleanup #61415

Merged
merged 1 commit into from May 13, 2019
Merged

wireshark: cleanup #61415

merged 1 commit into from May 13, 2019

Conversation

teto
Copy link
Member

@teto teto commented May 13, 2019

the call to fixCmakeFiles looks useless and just pollutes git status when developing
on wireshark.
I also removed an old variable that generated a warning.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

the call to fixCmakeFiles looks useless and just pollutes git status when developing
on wireshark.
I also removed an old variable that generated a warning.
@teto
Copy link
Member Author

teto commented May 13, 2019

I wouldn't mind adding
"-DCMAKE_EXPORT_COMPILE_COMMANDS=YES"
but I guess if it were acceptable it would be done systemwide ?

@ofborg ofborg bot requested review from bjornfor and fpletz May 13, 2019 02:04
@offlinehacker offlinehacker merged commit 053b58a into NixOS:master May 13, 2019
@teto teto deleted the wireshark_cleanup branch May 13, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants