Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: m-labs/nmigen
base: 958cb18b886a
Choose a base ref
...
head repository: m-labs/nmigen
compare: 3e58202e7024
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on May 12, 2019

  1. hdl: make all public Value classes other than Record final. 

    In some cases, nMigen uses type() instead of isinstance() to dispatch
on types. Make sure all such uses of type() are robust; in addition,
make it clear that nMigen AST classes are not meant to be subclassed.
(Record is an exception.)

Fixes #65.
    whitequark committed May 12, 2019
    Copy the full SHA
    3e58202 View commit details
    Browse the repository at this point in the history