Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7ec6169b88b9
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d64a36a2e7c2
Choose a head ref
  • 8 commits
  • 3 files changed
  • 4 contributors

Commits on May 13, 2019

  1. python37Packages.aiorpcx: 0.10.4 -> 0.10.5 (#57380)

    Semi-automatic update generated by
    https://github.com/ryantm/nixpkgs-update tools. This update was made
    based on information from
    https://repology.org/metapackage/python3.7-aiorpcx/versions
    
    (cherry picked from commit 5b0502d)
    r-ryantm authored and joachifm committed May 13, 2019

    Verified

    This commit was signed with the committer’s verified signature. The key has been revoked.
    joachifm Joachim F.
    Copy the full SHA
    9e565d9 View commit details
  2. python3Packages.aiorpcx: 0.10.5 -> 0.17.0 (electrum dep)

    (cherry picked from commit ae98b68)
    dtzWill authored and joachifm committed May 13, 2019

    Verified

    This commit was signed with the committer’s verified signature. The key has been revoked.
    joachifm Joachim F.
    Copy the full SHA
    f1ba980 View commit details
  3. zbar: 0.10 -> 0.22

    The original upstream at http://zbar.sourceforge.net/ has not produced a
    new release or a new commit on their repository in about 7 years. Most
    distros (Debian, Gentoo, Arch, ...) have switched already to the more
    maintained fork at https://github.com/mchehab/zbar
    
    Update dependencies from qt4 to qt5, reducing "electrum" closure size in
    the process (now only depends on one Qt version).
    
    (cherry picked from commit 57ffe86)
    delroth authored and joachifm committed May 13, 2019

    Partially verified

    This commit is signed with the committer’s verified signature. The key has been revoked.
    joachifm’s contribution has been verified via GPG key.
    We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
    Copy the full SHA
    5287da0 View commit details
  4. Verified

    This commit was signed with the committer’s verified signature. The key has been revoked.
    joachifm Joachim F.
    Copy the full SHA
    49dd634 View commit details
  5. electrum: fetch from official site, check signature (manually)

    (cherry picked from commit 9cae933)
    dtzWill authored and joachifm committed May 13, 2019

    Verified

    This commit was signed with the committer’s verified signature. The key has been revoked.
    joachifm Joachim F.
    Copy the full SHA
    265b4d3 View commit details
  6. electrum: fixup Exec lines in .desktop

    Not sure why upstream added $HOME/.local/bin to $PATH for these,
    but IMO that is for users to handle as they see fit.
    
    And it's not very nix-like :).
    
    (cherry picked from commit a879c72)
    dtzWill authored and joachifm committed May 13, 2019

    Verified

    This commit was signed with the committer’s verified signature. The key has been revoked.
    joachifm Joachim F.
    Copy the full SHA
    e1d5e30 View commit details
  7. electrum: grab tests from github, but use signed sources

    Not crazy about this solution, but seems better than
    not running tests or ignoring upstream's signatures.
    
    (cherry picked from commit 66493d7)
    dtzWill authored and joachifm committed May 13, 2019

    Verified

    This commit was signed with the committer’s verified signature. The key has been revoked.
    joachifm Joachim F.
    Copy the full SHA
    2ee408d View commit details
  8. Merge pull request #61437 from joachifm/electrum-release-19.03

    [Backport] Electrum bumps for 19.03
    joachifm authored May 13, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    d64a36a View commit details
Showing with 51 additions and 54 deletions.
  1. +29 −8 pkgs/applications/misc/electrum/default.nix
  2. +2 −2 pkgs/development/python-modules/aiorpcx/default.nix
  3. +20 −44 pkgs/tools/graphics/zbar/default.nix
37 changes: 29 additions & 8 deletions pkgs/applications/misc/electrum/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{ stdenv, fetchFromGitHub, python3, python3Packages, zbar, secp256k1 }:
{ stdenv, fetchurl, fetchFromGitHub, python3, python3Packages, zbar, secp256k1 }:

let
version = "3.3.5";

qdarkstyle = python3Packages.buildPythonPackage rec {
pname = "QDarkStyle";
version = "2.5.4";
@@ -10,19 +12,35 @@ let
};
doCheck = false; # no tests
};

# Not provided in official source releases, which are what upstream signs.
tests = fetchFromGitHub {
owner = "spesmilo";
repo = "electrum";
rev = version;
sha256 = "11rzzrv5xxqazcb7q1ig93d6cisqmd1x0jrgvfgzysbzvi51gg11";

extraPostFetch = ''
mv $out ./all
mv ./all/electrum/tests $out
'';
};
in

python3Packages.buildPythonApplication rec {
pname = "electrum";
version = "3.3.4";
inherit version;

src = fetchFromGitHub {
owner = "spesmilo";
repo = "electrum";
rev = version;
sha256 = "0yxdpc602jnd14xz3px85ka0b6db98zwbgfi9a3vj8p1k3mmiwaj";
src = fetchurl {
url = "https://download.electrum.org/${version}/Electrum-${version}.tar.gz";
sha256 = "1csj0n96zlajnrs39wsazfj5lmy7v7n77cdz56lr8nkmchh6k9z1";
};

postUnpack = ''
# can't symlink, tests get confused
cp -ar ${tests} $sourceRoot/electrum/tests
'';

propagatedBuildInputs = with python3Packages; [
aiorpcx
aiohttp
@@ -64,7 +82,10 @@ python3Packages.buildPythonApplication rec {
rm -rf $out/${python3.sitePackages}/nix
substituteInPlace $out/share/applications/electrum.desktop \
--replace "Exec=electrum %u" "Exec=$out/bin/electrum %u"
--replace 'Exec=sh -c "PATH=\"\\$HOME/.local/bin:\\$PATH\"; electrum %u"' \
"Exec=$out/bin/electrum %u" \
--replace 'Exec=sh -c "PATH=\"\\$HOME/.local/bin:\\$PATH\"; electrum --testnet %u"' \
"Exec=$out/bin/electrum --testnet %u"
'';

checkInputs = with python3Packages; [ pytest ];
4 changes: 2 additions & 2 deletions pkgs/development/python-modules/aiorpcx/default.nix
Original file line number Diff line number Diff line change
@@ -2,12 +2,12 @@

buildPythonPackage rec {
pname = "aiorpcx";
version = "0.10.4";
version = "0.17.0";

src = fetchPypi {
inherit version;
pname = "aiorpcX";
sha256 = "15jhklvl0ncy3mb2h9zkahky9fzzr1amgjylm2k3mvlpyn2dbpz6";
sha256 = "14np5r75rs0v45vsv20vbzmnv3qisvm9mdllj1j9s1633cvcik0k";
};

propagatedBuildInputs = [ attrs ];
64 changes: 20 additions & 44 deletions pkgs/tools/graphics/zbar/default.nix
Original file line number Diff line number Diff line change
@@ -1,53 +1,35 @@
{ stdenv, fetchurl, imagemagickBig, pkgconfig, python2Packages, perl
, libX11, libv4l, qt4, lzma, gtk2, fetchpatch, autoreconfHook
{ stdenv, fetchFromGitHub, imagemagickBig, pkgconfig, python2Packages, perl
, libX11, libv4l, qt5, lzma, gtk2, xmlto, docbook_xsl, autoreconfHook
, enableVideo ? stdenv.isLinux
}:

let
inherit (python2Packages) pygtk python;
in stdenv.mkDerivation rec {
name = "${pname}-${version}";
pname = "zbar";
version = "0.10";
src = fetchurl {
url = "mirror://sourceforge/project/${pname}/${pname}/${version}/${name}.tar.bz2";
sha256 = "1imdvf5k34g1x2zr6975basczkz3zdxg6xnci50yyp5yvcwznki3";
version = "0.22";

src = fetchFromGitHub {
owner = "mchehab";
repo = "zbar";
rev = version;
sha256 = "0pz0vq6a97vnc3lcjw9k12dk2awgmws46cjfh16zin0jiz18d1xq";
};

patches = [
(fetchpatch {
name = "0001-Description-Linux-2.6.38-and-later-do-not-support-th.patch";
url = "https://git.recluse.de/raw/debian/pkg-zbar.git/35182c3ac2430c986579b25f1826fe1b7dfd15de/debian!patches!0001-Description-Linux-2.6.38-and-later-do-not-support-th.patch";
sha256 = "1zy1wdyhmpw877pv6slfhjy0c6dm0gxli0i4zs1akpvh052j4a69";
})
(fetchpatch {
name = "python-zbar-import-fix-am.patch";
url = "https://git.recluse.de/raw/debian/pkg-zbar.git/1f15f52e53ee0bf7b4761d673dc859c6b10e6be5/debian!patches!python-zbar-import-fix-am.patch";
sha256 = "15xx9ms137hvwpynbgvbc6zgmmzfaf7331rfhls24rgbnywbgirx";
})
(fetchpatch {
name = "new_autotools_build_fix.patch";
url = "https://git.recluse.de/raw/debian/pkg-zbar.git/2c641cc94d4f728421ed750d95d6d1c2d06a534d/debian!patches!new_autotools_build_fix.patch";
sha256 = "0jhl5jnnjhfdv51xqimkbkdvj8d38z05fhd11yx1sgmw82f965s3";
})
(fetchpatch {
name = "threading-fix.patch";
url = "https://git.recluse.de/raw/debian/pkg-zbar.git/d3eba6e2c3acb0758d19519015bf1a53ffb8e645/debian!patches!threading-fix.patch";
sha256 = "1jjgrx9nc7788vfriai4z26mm106sg5ylm2w5rdyrwx7420x1wh7";
})
];
nativeBuildInputs = [ pkgconfig xmlto autoreconfHook docbook_xsl ];

buildInputs =
[ imagemagickBig pkgconfig python pygtk perl libX11
lzma autoreconfHook ] ++
stdenv.lib.optionals enableVideo [ libv4l gtk2 qt4 ];
buildInputs = [
imagemagickBig python pygtk perl libX11
] ++ stdenv.lib.optionals enableVideo [
libv4l gtk2 qt5.qtbase qt5.qtx11extras
];

configureFlags = stdenv.lib.optionals (!enableVideo) [
configureFlags = [
"--with-dbusconfdir=$out/etc/dbus-1/system.d"
] ++ stdenv.lib.optionals (!enableVideo) [
"--disable-video" "--without-gtk" "--without-qt"
];

hardeningDisable = [ "fortify" ];

meta = with stdenv.lib; {
description = "Bar code reader";
longDescription = ''
@@ -57,15 +39,9 @@ in stdenv.mkDerivation rec {
EAN-13/UPC-A, UPC-E, EAN-8, Code 128, Code 39, Interleaved 2 of 5 and QR
Code.
'';
maintainers = with maintainers; [ raskin ];
maintainers = with maintainers; [ delroth raskin ];
platforms = platforms.unix;
license = licenses.lgpl21;
homepage = http://zbar.sourceforge.net/;
};

passthru = {
updateInfo = {
downloadPage = "http://zbar.sourceforge.net/";
};
homepage = https://github.com/mchehab/zbar;
};
}