Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] Backport GDM PAM fix (cherry-picked from master) #61450

Merged
merged 2 commits into from May 13, 2019
Merged

[19.03] Backport GDM PAM fix (cherry-picked from master) #61450

merged 2 commits into from May 13, 2019

Conversation

alexeymuranov
Copy link
Contributor

Motivation for this change

#21860 is still an issue on 19.03. In particular, GDM does not unlock GNOME keyring on login.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alexeymuranov alexeymuranov mentioned this pull request May 13, 2019
Merged
7 tasks
@c0bw3b
Copy link
Contributor

c0bw3b commented May 13, 2019

@worldofpeace since you tested this properly on master -> good for you?

cc @NixOS/backports FYI -- consider this bugfix

@worldofpeace
Copy link
Contributor

I think I can vm test it identically and see if there's no issues.

worldofpeace
worldofpeace approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the same test as in #21860 (comment) ✔️

@worldofpeace worldofpeace merged commit 3adb08f into NixOS:staging-19.03 May 13, 2019
@worldofpeace
Copy link
Contributor

Thanks @alexeymuranov for the backport ✨

@alexeymuranov alexeymuranov deleted the backport-gdm_pam_fix-to-19.03 branch May 23, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexeymuranov @c0bw3b @worldofpeace @outergod