Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qscintilla: add qtmacextras to propagatedBuildInputs on darwin #61001

Merged
merged 1 commit into from May 11, 2019
Merged

qscintilla: add qtmacextras to propagatedBuildInputs on darwin #61001

merged 1 commit into from May 11, 2019

Conversation

ryan4729
Copy link
Contributor

@ryan4729 ryan4729 commented May 5, 2019

Motivation for this change

I found that qgis failed to build on macOS because python3Packages.qscintilla-qt5 was failing. The problem was that qtmacextras needs to be in the buildInputs of python3Packages.qscintilla-qt5. This change adds qtmacextras to propagatedBuildInputs of qscintilla. I wasn't sure if this is the right change, or if I should add qtmacextras directly to python3Packages.qscintilla-qt5.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 5, 2019
@ofborg ofborg bot requested a review from peterhoeg May 5, 2019 18:31
@c0bw3b c0bw3b merged commit c162ccf into NixOS:master May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryan4729 @c0bw3b