html: Add a testcase for submit event reentrancy protection #16811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
3 tasks
domenic
approved these changes
May 14, 2019
html/semantics/forms/form-submission-0/form-submission-algorithm.html
Outdated
Show resolved
Hide resolved
| let test10 = async_test('Cannot navigate (after constructing the entry list)'); | ||
| test10.step(() => { | ||
|
|
||
| async_test(t => { |
There was a problem hiding this comment.
Do you think this style of test is better than the counter style used above? If so, maybe add a comment?
There was a problem hiding this comment.
I'd like to test which one of two click()s submits the form. I'll add a comment.
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
May 15, 2019
Fixes #4620. This flag prevents reentrancy into the submission algorithm during submit or invalid events. Blink and Gecko implement this for submit only; WebKit implements it for both. The specification chooses WebKit's behavior. Tests: web-platform-tests/wpt#16811
domenic
approved these changes
May 15, 2019
html/semantics/forms/form-submission-0/form-submission-algorithm.html
Outdated
Show resolved
Hide resolved
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
Specification change: whatwg/html#4621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specification: whatwg/html#4621