Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtcreator: 4.6.2 -> 4.9.0 #61453

Closed
wants to merge 1 commit into from
Closed

qtcreator: 4.6.2 -> 4.9.0 #61453

wants to merge 1 commit into from

Conversation

SRGOM
Copy link
Member

@SRGOM SRGOM commented May 13, 2019

Continues: #61448

  • Updated qtcreator from 4.6.2 to 4.9.0
  • Added myself as maintainer
  • Tested on local machine. Did not test arm patch.
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SRGOM
qtcreator: 4.6.2 -> 4.9.0
b741067 
* Updated qtcreator from 4.6.2 to 4.9.0
* Added myself as maintainer
* Tested on local machine. Did not test arm patch.
@SRGOM SRGOM mentioned this pull request May 13, 2019
Closed
@Lassulus
Copy link
Member

@GrahamcOfBorg build qtcreator

@Lassulus
Copy link
Member

would be nice if the aarch64 version could also be fixed

apeyroux
apeyroux approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@apeyroux apeyroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build and test with nix-review pr 61453

@deadloko
Copy link
Contributor

deadloko commented May 15, 2019 •
edited

Done the same thing in #61348 . Our commits for qtcreator update is identical. I'l need to rebase my branch if it gets in.
Edit: Patch for botan (aarch64 compability) isn't needed anymore, i think, cause there is not botan dependency in new qtcreator.

@SRGOM
Copy link
Member Author

SRGOM commented May 16, 2019

Hi I cannot spend much more time on this. Thanks. As my github bio states (since yesterday), I never mind people picking up my PRs- not looking for any credit here, just trying to help out by spending the minimum time I can.

tomberek
tomberek reviewed May 21, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs on Ubuntu, but requires something like:

env LD_LIBRARY_PATH=/nix/store/ggnnq21w3bwxaw5hjl7clmwv2dvs9dy4-qtbase-5.12.0/lib ./results/qtcreator/bin/qtcreator

@SRGOM
Copy link
Member Author

SRGOM commented May 27, 2019

I missed @deadloko's comment, closing in favor of #61348. Please feel free to add me to maintainers if I can help in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek left review comments

@apeyroux apeyroux apeyroux approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SRGOM @Lassulus @deadloko @tomberek @apeyroux