New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading old waypoints from savegame version 72 causes crash #7587
Comments
Purely for informational purposes, can you try with latest master as well? There's been some changes in that area - #7544 comes to mind |
The same savegame, loaded in the latest master (20190511) crashes immediately on load, but with a different assertion (Assertion failed at line 113 of d:\a\1\s\src\core\pool_type.hpp: index < this->first_unused). Crash files have been attached. |
Investigation shows that it's crashing on tile 50011, which looks like it's a RailTileType of Nothing special about the waypoint on first glance... With bisecting, I nailed down the crash to 2646a99 . There is a change in afterload.cpp in there... |
The issue is, as far as I can tell, that at that point in the loading sequence waypoint still has tiletype of |
With the following diff I was able to load the save in current master: (Though the game crashes somewhere in YAPF after running for a few ticks - possibly because there's a depot tile pretending to be a railtrack)
which outputs
and looks like: I notice that neither of these tiles are apparently stored in the old WAYP save block, which will presumably be why they're getting converted to depots instead. As to why they're not in the WAYP block... |
Version of OpenTTD
1.9.1 stable
Expected result
The savegame loads and simulates normally.
Actual result
The savegame "Sundinghattan Transport, 10th Dec 2110.sav" (#1131) always crashes on load (after a few game ticks) with "NOT_REACHED triggered at line 2711 of d:\a\1\s\src\rail_cmd.cpp". Crash files have been attached.
This is probably caused by an invalid rail track tile being accessed.
Steps to reproduce
Load the attached savegame and wait a few game ticks.
The text was updated successfully, but these errors were encountered: