Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openscad: Darwin support and tidy #61393

Merged
merged 1 commit into from May 13, 2019
Merged

openscad: Darwin support and tidy #61393

merged 1 commit into from May 13, 2019

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Darwin support

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels May 12, 2019
@ofborg ofborg bot requested review from 7c6f434c, the-kenny and bjornfor May 12, 2019 20:27
@7c6f434c
Copy link
Member

@GrahamcOfBorg build openscad

@bjornfor bjornfor merged commit d5ed704 into NixOS:master May 13, 2019
@thefloweringash thefloweringash deleted the openscad-darwin branch May 13, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thefloweringash @7c6f434c @bjornfor