Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openra: 20181215 -> 20190314 + updated other engine releases and mods #61394

Merged
merged 1 commit into from May 20, 2019
Merged

openra: 20181215 -> 20190314 + updated other engine releases and mods #61394

merged 1 commit into from May 20, 2019

Conversation

msteen
Copy link
Contributor

@msteen msteen commented May 12, 2019 •
edited

Motivation for this change

Updated the OpenRA engine releases and updated the mods for which the bleeding edge versions were known to work. Both the updated engine releases and mods have been checked to build and run, although they have not been thoroughly tested (e.g. full play through), because doing so would take too much time.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@msteen msteen changed the title openra: updated mods openra: 20181215 -> 20190314 + updated other engine releases and mods May 12, 2019
@FRidh
Copy link
Member

FRidh commented May 14, 2019

@GrahamcOfBorg build openra

@c0bw3b c0bw3b mentioned this pull request May 20, 2019
Closed
10 tasks
@aanderse aanderse merged commit 2256b56 into NixOS:master May 20, 2019
@aanderse
Copy link
Member

Thanks @msteen 🎉

@c0bw3b
Copy link
Contributor

c0bw3b commented May 20, 2019

@msteen @aanderse could you recheck bleed build in this?

I got a hash mismatch on my end (with nix-review):

hash mismatch in fixed-output derivation '/nix/store/2f3hijxy1h9y5n94414brfd0x2m59gg4-source':
  wanted: sha256:19fjzwgmfdf832c6b1x885kaiyck03kpiba0qpsxvps04i7b3vj4
  got:    sha256:0f1fpf37ms8d7fhlh3rjzsxsk9w23iyi3phs2i7g561292d5rk3l
cannot build derivation '/nix/store/ha01dcp1wsniq9zzhd0b1laxa7ngryb5-openra-bleed-8ee1102.drv': 1 dependencies couldn't be built

@aanderse aanderse mentioned this pull request May 20, 2019
Merged
10 tasks
@aanderse
Copy link
Member

@c0bw3b you are correct. Please see #61749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@msteen @FRidh @aanderse @c0bw3b