Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kitty wrapper on MacOS #61369

Merged
merged 2 commits into from May 13, 2019
Merged

Fix Kitty wrapper on MacOS #61369

merged 2 commits into from May 13, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Closes #61231

Apply kovidgoyal/kitty@bdeec61 and kovidgoyal/kitty@af2c9a4 as a patch

Refs kovidgoyal/kitty#1539

The patch can be removed once the changes referenced land in a release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rvolosatovs rvolosatovs mentioned this pull request May 12, 2019
Closed
@rvolosatovs
Copy link
Member Author

@veprbl

@veprbl veprbl merged commit 73265c1 into NixOS:master May 13, 2019
veprbl pushed a commit that referenced this pull request May 13, 2019
@rvolosatovs @veprbl
kitty: apply patch on Darwin for running as symlink
8fd6e72 
(cherry picked from commit 7da5708)

cc #61369
veprbl pushed a commit that referenced this pull request May 13, 2019
@rvolosatovs @veprbl
kitty: symlink the deref binary
af657b7 
(cherry picked from commit 240fce7)

cc #61369
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label May 13, 2019
@veprbl
Copy link
Member

veprbl commented May 13, 2019

@rvolosatovs Thank you!

@rvolosatovs rvolosatovs deleted the fix/kitty branch May 13, 2019 15:05
@rvolosatovs rvolosatovs mentioned this pull request May 26, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kitty wrapper does not work on MacOS
2 participants
@rvolosatovs @veprbl