build: move needsHashRewrite initialization to startBuilder #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of useChroot is not set yet in the constructor, resulting in hash rewriting being enabled in certain cases where it should not be. Fixes NixOS#2801
LnL7
changed the title
|
I applied the second commit (d75bdb5) with the newly added test to master and confirmed it fails. I then applied the second commit, and indeed the test fails. Nice work! Nice to see the test, too! Also, rebasing my diff-hook patches on top allowed them to work, too. Nice. Thank you! |
|
Maybe it's better to turn this into a method, so we don't have to worry about the initialization order? I.e. bool needsHashRewrite() {
#if __linux__
return !useChroot;
#else
return true;
#endif
} |
|
Yay! Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of useChroot is not set yet in the constructor, resulting in
hash rewriting being enabled in certain cases where it should not be.
Fixes #2801
/cc @grahamc