Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

octoprint: fix held back jinja2 dependency #61407

Merged
merged 2 commits into from May 13, 2019
Merged

octoprint: fix held back jinja2 dependency #61407

merged 2 commits into from May 13, 2019

Conversation

mvnetbiz
Copy link
Contributor

@mvnetbiz mvnetbiz commented May 12, 2019 •
edited

Octoprint holds back python jinja2 package due to breaking changes.
nixpkgs' jinja2 recently changed to running tests, but the octoprint
version fails building due to having an older pytest configuration,
and this versions pypi release doesn't have the tests dir distributed in
the tarball anyways.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mvnetbiz
octoprint: fix held back jinja2 dependency
2a96ed5 
Octoprint holds back python jinja2 package due to breaking changes.
nixpkgs' jinja2 recently changed to running tests, but the octoprint
version fails building due to having an older pytest configuration,
and this versions pypi release doesn't have the tests dir distributed in
the tarball anyways.
@mvnetbiz mvnetbiz mentioned this pull request May 12, 2019
Closed
@ofborg ofborg bot requested a review from abbradar May 12, 2019 23:57
@marsam
Copy link
Contributor

marsam commented May 13, 2019

@GrahamcOfBorg build octoprint

@marsam marsam merged commit a459734 into NixOS:master May 13, 2019
@marsam
Copy link
Contributor

marsam commented May 13, 2019

@mvnetbiz thanks for looking into this. I've added a fix for the darwin build, I hope you don't mind.

@mvnetbiz mvnetbiz deleted the octoprint-jinja2 branch November 28, 2020 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvnetbiz @marsam