wpt: Support http://host:80/ at EventListener / incumbent test #16800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 13, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1610097
branch
from
2ee6109
to
62a6c4b
Compare
MessageEvent's origin attribute will be
http://hostname
instead of
http://hostname:80
in case that the port number is HTTP standard port number, i.e. 80.
Usually this is not a problem because wptserve runs with port=8001
by default, but w3c-test.org runs with port=80.
http://w3c-test.org/dom/events/EventListener-incumbent-global-2.sub.html
This patch supports such a case.
Bug: 622974
Change-Id: I4567de3f5f12ae42c222229eafafecbbe72129e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610097
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659871}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1610097
branch
from
62a6c4b
to
0a81584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessageEvent's origin attribute will be
http://hostname
instead of
http://hostname:80
in case that the port number is HTTP standard port number, i.e. 80.
Usually this is not a problem because wptserve runs with port=8001
by default, but w3c-test.org runs with port=80.
http://w3c-test.org/dom/events/EventListener-incumbent-global-2.sub.html
This patch supports such a case.
Bug: 622974
Change-Id: I4567de3f5f12ae42c222229eafafecbbe72129e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610097
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659871}