Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2: 3.4.1 -> 3.5.0 #61455

Merged
merged 1 commit into from May 13, 2019
Merged

radare2: 3.4.1 -> 3.5.0 #61455

merged 1 commit into from May 13, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented May 13, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from dtzWill May 13, 2019 13:44
@Mic92
Copy link
Member Author

Mic92 commented May 13, 2019

@GrahamcOfBorg build radare2

@ofborg ofborg bot requested a review from 7c6f434c May 13, 2019 14:24
@Mic92 Mic92 merged commit 220daf5 into NixOS:master May 13, 2019
@Mic92 Mic92 deleted the radare2 branch May 13, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Mic92