Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r19.03] k2pdfopt: patch custom leptonica with security fixes #61476

Merged
merged 1 commit into from May 15, 2019
Merged

[r19.03] k2pdfopt: patch custom leptonica with security fixes #61476

merged 1 commit into from May 15, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 13, 2019

Motivation for this change

Backport of #61302 to 19.03

This does weirdly mean that 19.03 would have two copies of leptonica-CVE-2018-3836.patch, but all the ways I can think of dealing with that feel like they introduce more churn than is worth it for a stable branch. What's more, it's a stable branch and it's not like this duplication will be a weight around our necks to inherit forever.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
k2pdfopt: patch custom leptonica with security fixes
3a0628c 
this is what you get to inherit if you insist on old versions.

(cherry picked from commit a7b3972)
@c0bw3b c0bw3b added 1.severity: security 8.has: port to stable A PR already has a backport to the stable release. labels May 15, 2019
c0bw3b
c0bw3b approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review is good and it runs

@c0bw3b c0bw3b merged commit 08b14d4 into NixOS:release-19.03 May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @c0bw3b