Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anbox: unstable-2019-03-07 -> unstable-2019-05-03 #61477

Merged
merged 1 commit into from May 17, 2019
Merged

Conversation

Lucus16
Copy link
Contributor

@Lucus16 Lucus16 commented May 14, 2019

Motivation for this change

This fixes a build issue with protobuf that was seemingly resolved
upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This fixes a build issue with protobuf that was seemingly resolved
upstream.
@aanderse
Copy link
Member

@Lucus16 as someone who has never ran anbox before I'm having some issues with it.

When I compile your branch I see anbox, anbox-application-manager and list_cpu_features under the bin directory. The anbox-application-manager is not executable so I tried the anbox executable instead. It launches a window which told me to run this instead: anbox launch --package=org.anbox.appmgr --component=org.anbox.appmgr.AppViewActivity. When I ran that command the window eventually timed out and closed with [daemon.cpp:61@Run] Application manager service is not running yet.

Could you let me know how I can properly test this please?

@c0bw3b
Copy link
Contributor

c0bw3b commented May 15, 2019

I believe you need to have some kernel modules loaded. This is just the graphical frontend.
On master there is a module taking care of the system config.

@Lucus16
Copy link
Contributor Author

Lucus16 commented May 15, 2019

I must admit I didn't check execution in detail, just that the binaries run at all. I wanted to play around with Anbox, but found the build broken, so I fixed that first. I figured if it turns out to be broken at runtime, I could make a separate issue for that, since fixing the build is already an improvement regardless. Should you want to test it in more detail, I believe the module mentioned is the best way. If you'd rather not change your configuration, you can just read through the module to see what steps it takes.

@danielfullmer
Copy link
Contributor

Tested and works fine for me using the nixos module

@aanderse
Copy link
Member

@GrahamcOfBorg build anbox

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aarch64-linux failure seems to be existing before this change anyways 😞

@danielfullmer thanks for your testing
@Lucus16 LGTM 👍

@aanderse aanderse merged commit 53b011a into NixOS:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants