Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxslt: make ID generation deterministic #61478

Closed
wants to merge 1 commit into from
Closed

libxslt: make ID generation deterministic #61478

wants to merge 1 commit into from

Conversation

jbboehr
Copy link
Contributor

@jbboehr jbboehr commented May 14, 2019 •
edited

Motivation for this change

ID generation in docbook HTML is non-deterministic [0]. This commit
pulls in a patch from Debian's libxslt_1.1.32-2.debian.tar.xz
Also refer to the relevant bugs filed in GNOME [1] and Debian [2].

This particular change was a result of looking into non-determinism in the opensc package's HTML documentation.

I will note there was some concern voiced [3] about the quality of the patch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edolstra May 14, 2019 00:38
@joachifm
Copy link
Contributor

Is it possible to fetch the patch from an external source?

@jbboehr
libxslt: make ID generation deterministic
b7b313d 
ID generation in docbook HTML is non-deterministic [0]. This commit
pulls in a patch from Debian's libxslt_1.1.32-2.debian.tar.xz
Also refer to the relevant bugs filed in GNOME [1] and Debian [2].

[0]: https://r13y.com/diff/31b703000e1c2d5a8ef2ef416a450f6e5505baa62ab9d0434fd4d359979562c3-cb7fa3904384d7606b65c421aeb1ab34f97991356c4099571b067586450c0e91.html
[1]: https://bugzilla.gnome.org/show_bug.cgi?id=751621
[2]: https://bugs.debian.org/823857
@jbboehr jbboehr force-pushed the libxslt-determinism-patch branch from 0a52752 to b7b313d Compare May 14, 2019 19:59
@joachifm
Copy link
Contributor

Hm, having looked closer at the patch reviews, I'm not sure this should be merged

Quoting https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902051

It's not immediately clear how the patch can be fixed, since it relies
on an assumption that is no longer valid. Thus, I think the patch
should be backed out until we can figure out the correct way to make
generate-id() deterministic. Unfortunately, this will cause a
regression in reproducibility, but I think that's outweighed by the
breakage.

I'll defer to somebody else to determine what to do, but if we do want this, it needs to go via staging.

@jbboehr
Copy link
Contributor Author

jbboehr commented May 15, 2019

Yeah, I was on the fence as well, but it was added in Debian, and I figured I'd at least get it registered in the issue tracker.

@FRidh
Copy link
Member

FRidh commented May 28, 2019

Thanks. Until there is a good solution I am closing this PR.

@FRidh FRidh closed this May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: reproducible builds 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbboehr @joachifm @FRidh