New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simgrid: 3.21 -> 3.22.2 #61462
simgrid: 3.21 -> 3.22.2 #61462
Conversation
- GitHub -> Framagit (SimGrid main repo has moved) - Test binaries must now be explicitly compiled (`make tests`) - Fix broken documentation link
This commit changes how failing tests are ignored. - Previously, the whole checkPhase was overridden. - Now, preCheck generates a ctest ignore file. ctest doc: https://gitlab.kitware.com/cmake/community/wikis/doc/ctest/Testing-With-CTest#customizing-ctest
@GrahamcOfBorg build simgrid |
@mpoquet Do you know if python bindings are working in the current version? When I built this locally I see |
@aanderse SimGrid integration tests execute the tesh SimGrid internal script, that runs a process and checks whether its output is the expected one. The Python dependency comes from tesh. The python binding is experimental in SimGrid-3.22.2 — I'm part of the SimGrid dev team btw. Additionally, explicitly setting |
@mpoquet sounds good, just wanted to make sure. Thanks! |
Motivation for this change
Keep nixpkgs's SimGrid up-to-date.
This commit does the following.
make tests
. This is now required as callingmake
without parameter no longer build test binaries.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)