hdf4: fix tests on some machines #61059
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The hdf4 package has some problems with tests failing on certain machines. Based on my testing, a particular machine will either fail or pass reliably. I have not seen any transient failures.
I discovered this issue because the Hydra builder "ike" failed to build this package and therefore one of my builders attempted to build it and also failed. The build previously succeeded on builder "t4a". I tested both commits, and both times was able to reproduce the failure, meaning that this is not a regression.
Here are the results of tests on different machines:
All of these test were done with sandboxing enabled.
Things done
Interestingly, the most reliable way I can find to fix the tests is to enable all the tests. The tests that were previously disabled pass on all machines I was able to test, including armv7l and aarch64, and they seem to make the other failing tests pass as well. I was not able to test macOS, but that can be done by ofborg.
I'm not sure what's going on here, but I suspect it fails on machines that have large numbers of cores, maybe due to a race condition.
cc @knedlsepp
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)