nodePackages: tslint: init at 5.16.0 #61487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this be also available in older node packages too? Like v8. |
|
@CMCDragonkai I was under the impression that it only needs to go into one, preferably the latest one, since it's a binary. |
|
|
|
Hmm ok. |
|
@jbboehr Why did you close this? |
|
any reason this wasn't merged? tslint is an important package for ts development \\ edit only now noticed that tslint is deprecated in favor of eslint. nvm :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Closes #61124
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)tslintdoesn't declare a dependency ontypescriptbut requires it in it's module path. The safest way to fix this is probably patching it's package.json or some currently non-existent option innode2nix, however I've simply symlinked it into it's module directory here. I believe this is safe based on my understanding of node2nix. If someone knows of a better way to solve this issue, let me know.I also did some git magic to not update all the node packages in this PR, not sure if that's preferred or not.