Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libnsl: 1.1.0 -> 1.2.0, drop included patches #61039

Merged
merged 1 commit into from May 12, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 6, 2019

Motivation for this change

Prefer released version rather than vendored patches :).

(release also touches up its pkgconfig files re:libtirpc)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented May 8, 2019

Looks like it's mostly triggering rebuilds on the many sets of kernel packages-- think it's good for master-- sound good?

@risicle
Copy link
Contributor

risicle commented May 11, 2019

Builds for me, non-nixos linux x86_64. nox-review too much for me though.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 12, 2019

@GrahamcOfBorg build postfix rpcbind tcp_wrappers

@c0bw3b c0bw3b merged commit 90f6472 into NixOS:master May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants