Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demoit: unstable-2019-03-29 -> unstable-2019-05-10 #61349

Merged
merged 2 commits into from May 12, 2019
Merged

demoit: unstable-2019-03-29 -> unstable-2019-05-10 #61349

merged 2 commits into from May 12, 2019

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented May 12, 2019 •
edited

Motivation for this change

Update demoit package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 12, 2019

I get a hash mismatch

hash mismatch in fixed-output derivation '/nix/store/bdaqiw5wq826pqdikzqc8a9rq1yw0a6j-source':
  wanted: sha256:03h0ad3v9xfigrppbcxiykzgcrv3dnarm7m1vixi2j4n1340f7q6
  got:    sha256:0l0pw0kzgnrk6a6f4ls3s82icjp7q9djbaxwfpjswbcfdzrsk4p2

@freezeboy
Copy link
Contributor Author

fixed sorry the old sha short circuited the build here, It rebuilt it with the new one, tell me if you want to squash both commits

c0bw3b
c0bw3b approved these changes May 12, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally

@c0bw3b c0bw3b merged commit c6e2638 into NixOS:master May 12, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented May 12, 2019

@freezeboy I squashed-merged directly.
Thanks.

tadeokondrak pushed a commit to tadeokondrak/nixpkgs that referenced this pull request May 17, 2019
@freezeboy @tadeokondrak
demoit: unstable-2019-03-29 -> unstable-2019-05-10 (NixOS#61349)
e76dc9b 
* demoit: unstable-2019-03-29 -> unstable-2019-05-10
@freezeboy freezeboy deleted the demoit-2019-05-10 branch July 10, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @c0bw3b