Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

g2o: init at 2019-04-07 #61344

Merged
merged 1 commit into from May 16, 2019
Merged

g2o: init at 2019-04-07 #61344

merged 1 commit into from May 16, 2019

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

I use this package.

Things done

Add g2o using the latest git revision. g2o does not have regular releases. It has a commit from 2017 tagged as a release, but this was added arbitrarily because someone wanted a release (RainerKuemmerle/g2o#194), so I thought it was better to just use the latest version.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lopsided98 lopsided98 force-pushed the g2o-init branch 2 times, most recently from b56ff6b to ee56f48 Compare May 14, 2019 19:01
aanderse
aanderse requested changes May 15, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things which are optional, but I would appreciate if you could change.

pkgs/development/libraries/g2o/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/g2o/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/g2o/default.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member

@GrahamcOfBorg build g2o

@aanderse aanderse merged commit 0b1a96c into NixOS:master May 16, 2019
@aanderse
Copy link
Member

@lopsided98 thanks for your contribution! 🎉

@lopsided98 lopsided98 deleted the g2o-init branch May 16, 2019 02:08
@lopsided98 lopsided98 mentioned this pull request May 18, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lopsided98 @aanderse