New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graalvm: rc15->19.0.0 #61475
graalvm: rc15->19.0.0 #61475
Conversation
@GrahamcOfBorg build graalvm |
@volth any other remarks except for the license in this PR? |
The build failed on linux, no idea where it failed |
@volth sorry was away from keyboard this evening, now rebased. I see you had the CI run on another PR :=) let's hope it runs, it was a typical mistake of not checking the hashes when I was changing revisions. |
Going to try again after your commit myself... (may take 40 mins), but the errors comes relatively early, they changes the spec of the mx config files where language isn't a valid key anymore. |
What errors are you getting, I tested your commit directly with (my nix is sandboxed) |
ah yes sorry, my miscommunication. I mean your changes to the graham's errors fixed it all :) changes to those hashes and version fixes the build for good |
We can look at doing that split, I assume the memory usage problem still needs fixing too? To be honest, I don't thing I will have time to fix this until August. This is such a tedious and time-consuming compilation. Maybe 19.0.2 has some memory improvements, we could start by bumping the version and see if the new minor versions compiles more easily? That nix-support directory, probably it's there but I delete it in the installPhase, will need to research. |
Timeout on graalvm8 on x86_64 linux, something which can be removed or its value increased? |
attribute 'postFixup' missing, |
@volth I will merge this, when you give me a thumbs up. |
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/how-to-compile-and-package-an-app-with-graalvm/3662/1 |
Motivation for this change
New release
Things done
Copied over some files that the handmade graal lib loader just couldn't find when compiling statically. Added postInstall check for static compilation as well. graalpython and graaljs repos are not on tagged revisions, there was clearly some screw up happening in the release of 19.0.0 where graalvm was released too fast and required changes which were added after graalpython and graaljs were released to tag 19.0.0
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)