Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graalvm: rc15->19.0.0 #61475

Merged
merged 7 commits into from Aug 2, 2019
Merged

graalvm: rc15->19.0.0 #61475

merged 7 commits into from Aug 2, 2019

Conversation

hlolli
Copy link
Member

@hlolli hlolli commented May 13, 2019

Motivation for this change

New release

Things done

Copied over some files that the handmade graal lib loader just couldn't find when compiling statically. Added postInstall check for static compilation as well. graalpython and graaljs repos are not on tagged revisions, there was clearly some screw up happening in the release of 19.0.0 where graalvm was released too fast and required changes which were added after graalpython and graaljs were released to tag 19.0.0

  • [ x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [ x ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented May 14, 2019

@GrahamcOfBorg build graalvm

@Mic92
Copy link
Member

Mic92 commented May 14, 2019

@volth any other remarks except for the license in this PR?

@hlolli
Copy link
Member Author

hlolli commented May 14, 2019

The build failed on linux, no idea where it failed

@hlolli
Copy link
Member Author

hlolli commented May 14, 2019

@volth sorry was away from keyboard this evening, now rebased. I see you had the CI run on another PR :=) let's hope it runs, it was a typical mistake of not checking the hashes when I was changing revisions.

@hlolli
Copy link
Member Author

hlolli commented May 14, 2019

Going to try again after your commit myself... (may take 40 mins), but the errors comes relatively early, they changes the spec of the mx config files where language isn't a valid key anymore.

@hlolli
Copy link
Member Author

hlolli commented May 15, 2019

What errors are you getting, I tested your commit directly with (my nix is sandboxed) NIX_PATH=nixpkgs=$PWD:nixpkgs-overlays=/ nix-build . -A graalvm8 --verbose and then I garbage collected all my generations, and downloaded all the hashes anew.It's not finished running, but I'm further in than all the bugs that I was fighting with.

@hlolli
Copy link
Member Author

hlolli commented May 15, 2019

ah yes sorry, my miscommunication. I mean your changes to the graham's errors fixed it all :) changes to those hashes and version fixes the build for good

@hlolli
Copy link
Member Author

hlolli commented Jun 21, 2019

We can look at doing that split, I assume the memory usage problem still needs fixing too?

To be honest, I don't thing I will have time to fix this until August. This is such a tedious and time-consuming compilation. Maybe 19.0.2 has some memory improvements, we could start by bumping the version and see if the new minor versions compiles more easily? That nix-support directory, probably it's there but I delete it in the installPhase, will need to research.

@ofborg ofborg bot requested a review from NeQuissimus June 21, 2019 17:40
@hlolli
Copy link
Member Author

hlolli commented Jun 21, 2019

Timeout on graalvm8 on x86_64 linux, something which can be removed or its value increased?

@FRidh
Copy link
Member

FRidh commented Jul 3, 2019

attribute 'postFixup' missing,

@ofborg ofborg bot requested a review from NeQuissimus July 31, 2019 19:49
@Mic92
Copy link
Member

Mic92 commented Aug 2, 2019

@volth I will merge this, when you give me a thumbs up.

@Mic92 Mic92 merged commit 90096c7 into NixOS:master Aug 2, 2019
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/how-to-compile-and-package-an-app-with-graalvm/3662/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants