Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddcci-driver: init at 0.3.2 #61387

Merged
merged 1 commit into from Jan 4, 2020
Merged

ddcci-driver: init at 0.3.2 #61387

merged 1 commit into from Jan 4, 2020

Conversation

bricewge
Copy link
Contributor

Motivation for this change

It adds a linux kernel driver for DDC/CI monitors. With it you can modify the brightness of your external monitor through sysfs, in the same way as with a laptop screen. acpilight is the recommended utility to achieve this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

JohnAZoidberg
JohnAZoidberg reviewed Jun 24, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work for you?
I'm having the same issues as many of the others: https://gitlab.com/ddcci-driver-linux/ddcci-driver-linux/issues
I haven't tried the udev rules that people are proposing but doing echo 'ddcci 0x37' | sudo tee /sys/bus/i2c/devices/i2c-<?>/new_device doesn't seem to work for me.

I'm on Linux 5.1.8 with an HP ZR24w connected over an HDMI to DVI adapter and the Intel i915 driver.

Your packaging seems fine, though.

@bricewge
Copy link
Contributor Author

Yes, of course, I'm using it daily through acpilight. Note that I rarely disconnect or reconnect the monitor so I'm not sure if hot-plugging is fail-proof.

Following is the configuration I'm using currently:

  boot.kernelModules = [
    "i2c-dev" # For ddcutil
    "ddcci"
    "ddcci-backlight"
  ];

  users.groups = {
    backlight = { };
    i2c = { }; # For ddcutil
  };

  boot.extraModulePackages = [ pkgs.linuxPackages.ddcci-driver ];

  services.udev.packages = with pkgs; [
    ddcutil
    acpilight
  ];

My setup is Linux 4.19.47 with a Benq GW2765 connected over a DVI to HDMI adpater and the Intel i915 driver.

@ryantm
Copy link
Member

ryantm commented Jan 4, 2020

@GrahamcOfBorg build linuxPackages.ddcci-driver

@ryantm ryantm merged commit e7e5fc9 into NixOS:master Jan 4, 2020
@JohnAZoidberg
Copy link
Member

Can be updated to v.0.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bricewge @ryantm @JohnAZoidberg