Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awesome: add optional gtk3 support (port to 19.03 branch) #61465

Merged
merged 1 commit into from May 14, 2019
Merged

awesome: add optional gtk3 support (port to 19.03 branch) #61465

merged 1 commit into from May 14, 2019

Conversation

stefano-m
Copy link
Contributor

Porting #61161 to release-19.03 Cc @rasendubi .
See also #61161 (comment)

Add optional gtk3 support to Awesome so that the beautiful.gtk module can be
used.

The beautiful.gtk uses lgi to obtain Gtk via gobject-introspect:

return require('lgi').Gtk

Since the current build does not include the typelib files needed, the above
call fails.

It turns out that both gtk3 and atk (Accessibility toolkit) are needed, so
this commit adds them as optional build inputs.

Setting gtk3Support to true e.g. in an overlay will make beautiful.gtk
work at the cost of an increased closure size (currently 99.6M vs 223.4M).

Add optional gtk3 support to Awesome so that the `beautiful.gtk` module can be
used.

The `beautiful.gtk` uses `lgi` to obtain Gtk via gobject-introspect:

    return require('lgi').Gtk

Since the current build does not include the typelib files needed, the above
call fails.

It turns out that both `gtk3` and `atk` (Accessibility toolkit) are needed, so
this commit adds them as optional build inputs.

Setting `gtk3Support` to `true` e.g. in an overlay will make `beautiful.gtk`
work at the cost of an increased closure size (currently 99.6M vs 223.4M).

Fixes #60538
@stefano-m stefano-m changed the title awesome: add optional gtk3 support awesome: add optional gtk3 support (port to 19.03 branch) May 13, 2019
@ofborg ofborg bot requested review from rasendubi and lovek323 May 13, 2019 20:21
@rasendubi rasendubi merged commit 4ed066f into NixOS:release-19.03 May 14, 2019
@rasendubi
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants