Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpPackages: add php packages #61466

Merged
merged 3 commits into from May 19, 2019
Merged

phpPackages: add php packages #61466

merged 3 commits into from May 19, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented May 13, 2019

Motivation for this change

Add php pakages:

  • pinba 1.1.1 (user for realtime monitoring)
  • event 2.5.0
  • protobuf 3.7.1

cc @etu

Who can help build a package? - https://github.com/badoo/pinba2 - Pinba is a statistics server using MySQL as an interface.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin
Copy link
Contributor Author

Izorkin commented May 13, 2019

@GrahamcOfBorg build php71Packages-unit.event php71Packages-unit.pinba php71Packages-unit.protobuf php72Packages-unit.event php72Packages-unit.pinba php72Packages-unit.protobuf php73Packages-unit.event php73Packages-unit.pinba php73Packages-unit.protobuf php71Packages.event php71Packages.pinba php71Packages.protobuf php72Packages.event php72Packages.pinba php72Packages.protobuf php73Packages.event php73Packages.pinba php73Packages.protobuf

@Izorkin
Copy link
Contributor Author

Izorkin commented May 14, 2019

@GrahamcOfBorg build php71Packages-unit.event php71Packages-unit.pinba php71Packages-unit.protobuf php72Packages-unit.event php72Packages-unit.pinba php72Packages-unit.protobuf php73Packages-unit.event php73Packages-unit.pinba php73Packages-unit.protobuf php71Packages.event php71Packages.pinba php71Packages.protobuf php72Packages.event php72Packages.pinba php72Packages.protobuf php73Packages.event php73Packages.pinba php73Packages.protobuf

@Izorkin
Copy link
Contributor Author

Izorkin commented May 15, 2019

@GrahamcOfBorg build php71Packages-unit.event php71Packages-unit.pinba php71Packages-unit.protobuf php72Packages-unit.event php72Packages-unit.pinba php72Packages-unit.protobuf php73Packages-unit.event php73Packages-unit.pinba php73Packages-unit.protobuf php71Packages.event php71Packages.pinba php71Packages.protobuf php72Packages.event php72Packages.pinba php72Packages.protobuf php73Packages.event php73Packages.pinba php73Packages.protobuf
php71Packages-unit.couchbase php72Packages-unit.couchbase php73Packages-unit.couchbase php71Packages.couchbase php72Packages.couchbase php73Packages.couchbase

@etu
Copy link
Contributor

etu commented May 15, 2019

I also don't see the need for: 02a5410

Because it adds more complexity than needed. And if you want to override libcouchbase, you can do it by on overlay or possibly using overrideAttrs.

Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See left notes.

@Izorkin
Copy link
Contributor Author

Izorkin commented May 15, 2019

I also don't see the need for: 02a5410

Because it adds more complexity than needed. And if you want to override libcouchbase, you can do it by on overlay or possibly using overrideAttrs.

How to use overrideAttrs in nur-packages?

@etu
Copy link
Contributor

etu commented May 17, 2019

phpPackages.event and phpPackages.protobuf is missing meta, as well, do you want to put yourself as mantainer on all these packages?

@Izorkin
Copy link
Contributor Author

Izorkin commented May 17, 2019

Updated meta.

@etu etu merged commit 87f62e8 into NixOS:master May 19, 2019
@Izorkin
Copy link
Contributor Author

Izorkin commented May 19, 2019

Thanks!

@Izorkin Izorkin deleted the pinba branch May 19, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants