Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel: Disable VirtualBox guest modules. #60938

Merged
merged 1 commit into from May 12, 2019
Merged

kernel: Disable VirtualBox guest modules. #60938

merged 1 commit into from May 12, 2019

Conversation

ambrop72
Copy link
Contributor

@ambrop72 ambrop72 commented May 4, 2019

These break the modules from VirtualBox additions. Fixes issue #58127.

I think this is the thing we should do for now. A proper but harder fix would be to extend the kernel-modules aggregator package (pkgs/os-specific/linux/kmod/aggregator.nix) to allow excluding some modules, and make the VirtualBox additions NixOS module set options to exclude the modules from the kernel (or not, if the user wants to use those).

This is also for 19.03 and 18.09.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ambrop72
kernel: Disable VirtualBox guest modules.
c6934f3 
These break the modules from VirtualBox additions. Fixes issue NixOS#58127.
flokli
flokli approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's fine, given options.virtualisation.virtualbox.guest.enable = true is what's setting boot.extraModulePackages = [ kernel.virtualboxGuestAdditions ];, and we can expect people to set this when trying to use virtualbox-specific guest features.

@flokli
Copy link
Contributor

flokli commented May 10, 2019

@jtojnar could you give this a test run?

@Yarny0
Copy link
Contributor

Yarny0 commented May 12, 2019

Review per https://nixos.org/nixpkgs/manual/#reviewing-contributions-package-updates

Reviewed points
  • package name fits guidelines (not changed)
  • package version fits guidelines (not changed)
  • package build on x86_64-linux
  • executables tested on x86_64-linux
  • all depending packages build (not tested)

Notes on testing:

  • Tested after rebasing onto current nixos-unstable channel (bc94dcf).
  • Booted x86_64-linux 4.19.41 (compiled with pull request applied) inside virtualbox.
  • Mounting a vboxsf filesystem with original guest additions 5.2.18 works without problems.
  • The video driver from the original guest additions 5.2.18 is apparently working -- checked with "Auto-resize Guest Display" option.
  • These kernel versions compile without error with the pull request applied: 4.4.179, 4.9.174, 4.14.117, 4.19.41, 5.0.14, 5.1 (tested by building the kernel config package and the kernel package with nix).
  • Besides 4.19.41, I haven't booted any of those kernels for testing.
Comments

@flokli flokli merged commit f2ac54d into NixOS:master May 12, 2019
@flokli
Copy link
Contributor

flokli commented May 14, 2019

backported to 19.03 in bfdb124.

@Yarny0 Yarny0 mentioned this pull request May 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ambrop72 @flokli @Yarny0