Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.bcc: use llvm 7.x #61474

Merged
merged 1 commit into from Jun 6, 2019
Merged

linuxPackages.bcc: use llvm 7.x #61474

merged 1 commit into from Jun 6, 2019

Conversation

lheckemann
Copy link
Member

This fixes a number of the tools on aarch64.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lheckemann
Copy link
Member Author

cc maintainers @Mic92 @thoughtpolice @ragnard

@thoughtpolice
Copy link
Member

@GrahamcOfBorg build linuxPackages.bpftrace

@thoughtpolice
Copy link
Member

Isn't llvmPackages_7 already the default?

a@link> nix-build --no-link -QA llvmPackages.llvm
/nix/store/0ylrvcslbf95qj9j889i84rkr6xc4sza-llvm-7.1.0

Or is it not the default on aarch64 yet?

@lheckemann
Copy link
Member Author

Oops, you're right. I originally had the problem (and made this change) on 19.03, where the default is still 5, but it should be fine on unstable actually. I'll rebase and retarget to 19.03.

@lheckemann lheckemann changed the base branch from master to release-19.03 May 15, 2019 04:31
@Mic92
Copy link
Member

Mic92 commented May 15, 2019

I think you need to rebase this further.

@lheckemann
Copy link
Member Author

I don't know what's going on here, git log origin/release-19.03..bcc-llvm7 only reports the one commit for me.

@lheckemann
linuxPackages.bcc: use llvm 7.x
2033835 
This fixes a number of the tools on aarch64.
@lheckemann lheckemann merged commit 00322cc into NixOS:release-19.03 Jun 6, 2019
@lheckemann lheckemann deleted the bcc-llvm7 branch June 6, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lheckemann @thoughtpolice @Mic92