Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xhr: Use .any.js syntax for access-control-{and-redirects-*,basic-allow-*} tests #16794

Merged
merged 1 commit into from May 14, 2019

Conversation

CYBAI
Copy link
Contributor

@CYBAI CYBAI commented May 13, 2019

Part of #11588

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@annevk
Copy link
Member

annevk commented May 13, 2019

Did you try running the tests btw? Any new failures discovered in browsers?

@CYBAI
Copy link
Contributor Author

CYBAI commented May 13, 2019

Did you try running the tests btw? Any new failures discovered in browsers?

Yes :) I only see one failure (Request is redirected to a same-origin resource file test case) in /xhr/access-control-and-redirects-async.any.js but I found I also get that test case failed locally in the original format 🤔

@annevk
Copy link
Member

annevk commented May 13, 2019

Hmm how? xhr/access-control-and-redirects-async.htm passes for me in Chrome and Firefox.

@CYBAI
Copy link
Contributor Author

CYBAI commented May 13, 2019

This is what I get in Firefox Nightly. I launch wpt serve with ./wpt serve. Did I miss something 🤔?

.any.js .htm
xhr/access-control-and-redirects-async.any.js xhr/access-control-and-redirects-async.htm

@annevk
Copy link
Member

annevk commented May 13, 2019

And you navigate the browser to http://web-platform.test:8000/xhr/access-control-and-redirects-async.htm?

@CYBAI
Copy link
Contributor Author

CYBAI commented May 13, 2019

And you navigate the browser to http://web-platform.test:8000/xhr/access-control-and-redirects-async.htm?

Ahh, I navigated it by http://localhost:8000/xhr/access-control-and-redirects-async.htm 😭
After navigating to http://web-platform.test:8000, I can pass the test case! Thanks!

@annevk annevk merged commit c73e256 into web-platform-tests:master May 14, 2019
@CYBAI CYBAI deleted the xhr-any-js branch May 14, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants