dom: createAttribute() should not produce a prefix #16810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 14, 2019
https://dom.spec.whatwg.org/#dom-document-createattribute document.createAttribute("foo:bar") created an Attr object with prefix="foo" localName="bar" namespaceURI=null. It should be one with prefix=null localName="foo:bar" namespaceURI=null. The new behavior matches to Firefox and Edge. Bug: 961328 Change-Id: If18c9c427dba3eaa38b3b69c32544ea8b91c2f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611059 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#659358}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1611059
branch
from
f4609fb
to
2d2aba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dom.spec.whatwg.org/#dom-document-createattribute
document.createAttribute("foo:bar") created an Attr object with
prefix="foo" localName="bar" namespaceURI=null. It should be
one with prefix=null localName="foo:bar" namespaceURI=null.
The new behavior matches to Firefox and Edge.
Bug: 961328
Change-Id: If18c9c427dba3eaa38b3b69c32544ea8b91c2f94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611059
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659358}