Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sfxr: init at 1.2.1 #61464

Merged
merged 1 commit into from May 19, 2019
Merged

sfxr: init at 1.2.1 #61464

merged 1 commit into from May 19, 2019

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented May 13, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg
Copy link
Member

Pretty cool program :D Everything seems to work: Creating, playing audio, modifying all kinds of sliders, exporting, importing.

@aanderse
Copy link
Member

@JohnAZoidberg thanks for your review 👍
@fgaz thanks for your contribution to nixpkgs! 🎉

@aanderse aanderse merged commit a0f36ab into NixOS:master May 19, 2019
@fgaz fgaz deleted the sfxr/init branch May 19, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgaz @JohnAZoidberg @aanderse