-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A better reference plane for the the ECI etc. frames. #2153
Conversation
not_null<MassiveBody const*> const centre) | ||
BodyCentredNonRotatingDynamicFrame( | ||
not_null<Ephemeris<InertialFrame> const*> const ephemeris, | ||
not_null<MassiveBody const*> const centre) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this change, we don't like the way that clang-format
does it.
// In coordinates, the third parameter is |polar_axis|, but we seem | ||
// to be a bit confused as to which of these things should be | ||
// vectors or bivectors here. | ||
// TODO(egg): Figure that out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels reasonable to use a bivector for the axis. I think we have a similar "confused" comment somewhere else.
This will make it possible to address #1841; additional logic would be needed for to properly address the irrelevance of the solar equator, other than that this is a simple matter of changing the following condition in the adapter.
Principia/ksp_plugin_adapter/ksp_plugin_adapter.cs
Lines 1922 to 1925 in 80be4b3
Note: this breaks tests (some values that were very small have become 0 because of the changes in (bi)equatorial), and it probably needs some new tests to check the orientation.