macOS Mojave: fix hang on launch #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Mojave, [NSApp menuBar] doesn't exist until after applicationDidFinishLaunching, causing `nsMenuBar` to be nil (and `Clear()` to never exit since `numberOfItems` is 0). Rather than restructuring the lifecycle of the app, just create our own menu bar and set it as the main menu.
|
|
|
The reason it was using the existing main menu is that it's the one created from this nib which IIRC was required for the default items in the system menu to work properly. E.g. that's where the |
|
Okay, it does still work using the .nib if the Xcode project is set up properly or if the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mojave, [NSApp menuBar] doesn't exist until after applicationDidFinishLaunching, causing
nsMenuBarto be nil (andClear()to never exit sincenumberOfItemsis 0). Rather than restructuring the lifecycle of the app, just create our own menu bar and set it as the main menu.