"ok" is not always okay #201
Closed
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a sketch has a "minor" problem, such as being self-intersecting, this can cause considerably confusion in subsequent groups, yet is not indicated in the group list. This commit makes the "ok" yellow in such cases. Note that the indication may not change immediately when a change leading to trouble is made, since the dependent groups are not recalculated on all changes.
whitequark
force-pushed
the
master
branch
3 times, most recently
from
371f33b to
fb1065d
Compare
|
@wpwrak Change looks good to me. Can you please rebase on master? |
|
@wpwrak ping |
|
I went ahead and merged this manually, with minor changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sketch may contain errors that cause later groups to fail, but the group list still says that everything is "ok". Here is an example:
not-okay.zip
g004-extrude is based on the outline in g003-sk-outline, which in turn uses geometry from g002-sk-bad-influence.
With this commit, the "ok" of a group containing a sketch with problems will be shown in yellow:
Note that this commit touches the same area a my previous DOF indication changed. Since each makes the color selection a little more complicated, I disentangled it here.
Addendum: the "ok" may not turn yellow immediate. E.g., in the above example, it remains green until the group is recalculated, which doesn't happen automatically/immediately in this case.