Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on close #388

Closed
starsolaris opened this issue Mar 20, 2019 · 2 comments
Closed

Crash on close #388

starsolaris opened this issue Mar 20, 2019 · 2 comments
Labels
bug Win32
Milestone
3.0

Comments

@starsolaris
Copy link

System information

SolveSpace version: 3.0~83a0a517; (build from https://ci.appveyor.com/project/whitequark/solvespace/build/artifacts)

Operating system: Windows 10

Expected behavior

SolveSpace should close

Actual behavior

SolveSpace crashed with error message:
File C:\projects\solvespace\src\platform\guiwin.cpp, line 459, function SolveSpace::Platform::MenuBarImplWin32: Win32 API call failed: DestroyMenu(hMenuBar).
Error: Неверный дескриптор меню.
("Invalid Menu Handle" in English)
@whitequark
Copy link
Contributor

Looks like:

If the specified window is a parent or owner window, DestroyWindow automatically destroys the associated child or owned windows when it destroys the parent or owner window. The function first destroys child or owned windows, and then it destroys the parent or owner window.

So there's probably a sequencing issue between destroying the window and its menu bar.

@whitequark
Copy link
Contributor

whitequark commented May 13, 2019 •
edited

Fixed in c44a471.

@whitequark whitequark added this to the 3.0 milestone May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Win32
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@whitequark @starsolaris