Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luajitPackages: Improve derivation names #63570

Merged
merged 1 commit into from Jun 24, 2019
Merged

luajitPackages: Improve derivation names #63570

merged 1 commit into from Jun 24, 2019

Conversation

Shados
Copy link
Member

@Shados Shados commented Jun 20, 2019

Motivation for this change

"lua" + lua.luaversion + "-" resolves to "lua51-" for both Lua 5.1 and LuaJIT packages. With this, LuaJIT packages instead get lua.name + "-", which currently resolves to "luajit-2.1.0-beta3-". This makes it easy to distinguish the two package sets in store paths, etc.

Things done
  • [x Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Shados
luajitPackages: Improve derivation names
48d3f66 
`"lua" + lua.luaversion + "-"` resolves to "lua51-" for both Lua
5.1 and LuaJIT packages. With this, LuaJIT packages instead get
`lua.name + "-"`, which currently resolves to "luajit-2.1.0-beta3-".
This makes it easy to distinguish the two in store paths etc.
@teto teto merged commit f2aa671 into NixOS:master Jun 24, 2019
@teto
Copy link
Member

teto commented Jun 24, 2019

thanks ! small change but quite useful in terms of UX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: lua 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shados @teto