Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.imgaug: mark as broken #63548

Merged
merged 1 commit into from Jun 23, 2019
Merged

pythonPackages.imgaug: mark as broken #63548

merged 1 commit into from Jun 23, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jun 20, 2019 •
edited

Motivation for this change

I was trying to fix this build, then gave up when i saw what it would take to implement opencv-python bindings. take a look if you are curious/crazy

Felt like just marking it as broken was the more correct thing to do than leaving it a false-positive.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner June 20, 2019 01:29
matthiasbeyer
matthiasbeyer requested changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you updating anything else in the same commit in that you mark the package as broken?

@jonringer
Copy link
Contributor Author

Because those are needed by the package, like I said, it seems like the more correct thing to push the work I did to get it closer to being unbroken, and then just document what's missing.

@matthiasbeyer
Copy link
Contributor

Okay. But please not in the same commit because ppl cannot easily revert the patch then.

@jonringer
Copy link
Contributor Author

I just removed the work i did, it didnt amount to much anyway.

matthiasbeyer
matthiasbeyer approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for your contribution!

@FRidh FRidh merged commit d27c1f6 into NixOS:master Jun 23, 2019
@jonringer jonringer deleted the mark_imgaug_broken branch July 9, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @matthiasbeyer @FRidh