Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luaPackages.luadbi-mysql: Fix linking issue #63547

Merged
merged 1 commit into from Jun 20, 2019
Merged

luaPackages.luadbi-mysql: Fix linking issue #63547

merged 1 commit into from Jun 20, 2019

Conversation

Shados
Copy link
Member

@Shados Shados commented Jun 20, 2019

Motivation for this change

Fixes an issue in the wake of #63108 being merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

vcunat
vcunat approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the prosody test, and it seems very unlikely to break anything.

vdemeester pushed a commit to vdemeester/nixpkgs that referenced this pull request Jun 20, 2019
@vcunat
Merge NixOS#63547: luaPackages.luadbi-mysql: Fix linking issue
e48b747 
Fixes the prosody test, and it seems very unlikely to break anything.
@vcunat
Copy link
Member

vcunat commented Jun 20, 2019

I'd prefer if some sane detection worked, e.g. via pkg-config, but let's at least fix the regression fast.

@vcunat vcunat merged commit 460217d into NixOS:master Jun 20, 2019
@Shados
Copy link
Member Author

Shados commented Jun 20, 2019

@vcunat the linking not finding stuff through "some sane detection [method]" is fundamentally an upstream issue in luarocks.

Their reasoning regarding disallowing split-prefix headers/libs/etc. is reasonable in the normal distro case, but if you're interested maybe you could try making a luarocks PR to add a config option to allow it?

@vcunat
Copy link
Member

vcunat commented Jun 20, 2019

Ah, right, I have seen the other upstream ticket actually (one about pkg-config), but I forgot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
6.topic: lua 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shados @vcunat