Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel 0.27.0 #63451

Closed
wants to merge 2 commits into from
Closed

Bazel 0.27.0 #63451

wants to merge 2 commits into from

Conversation

Profpatsch
Copy link
Member

I commented out the src deps for now. See commit.

bazel now uses python3 by default, and it didn’t build without adding python3 to the custom bash. I’m not sure this is the right thing to do. cc @mboes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @kalbasit @groodt

@Profpatsch
bazel: remove srcDeps from the build
13165f5 
They are not needed for the pure build, but are still relevant for
running the tests in the future.
@Profpatsch
bazel: 0.26.1 -> 0.27.0
e45d276
@kalbasit
Copy link
Member

I commented out the src deps for now. See commit.

I think that's fine given that we had to disable them in Bazel 0.26 anyway. Should we just remove the code, for now, to keep the derivation clean? We can file a separate PR with all of it re-enabled so we have something to start working on?

bazel now uses python3 by default, and it didn’t build without adding python3 to the custom bash. I’m not sure this is the right thing to do. cc @mboes

I think that this is fine as well. Last time I spoke to the Bazel team, they informed me that Python 3 is going to become the default Python interpreter for Bazel internals and possibly the default toolchain.

@kalbasit
Copy link
Member

@GrahamcOfBorg build bazel bazel.tests

@marsam
Copy link
Contributor

marsam commented Jun 20, 2019

Shall we close this PR in favor of #63532?

@mboes
Copy link
Contributor

mboes commented Jun 20, 2019

bazel now uses python3 by default, and it didn’t build without adding python3 to the custom bash. I’m not sure this is the right thing to do.

Sounds fine.

@FRidh FRidh mentioned this pull request Jun 20, 2019
Merged
10 tasks
@Profpatsch
Copy link
Member Author

This will be integrated in the other PR.

@Profpatsch Profpatsch closed this Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Profpatsch @kalbasit @marsam @mboes