Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.django-crispy-forms: init at 1.7.2 #63502

Closed
wants to merge 2 commits into from
Closed

python3Packages.django-crispy-forms: init at 1.7.2 #63502

wants to merge 2 commits into from

Conversation

aakropotkin
Copy link
Contributor

Motivation for this change

Required package for a project.

Things done

Added and tested "Django Cripsy Forms" Python Package.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aakropotkin aakropotkin requested a review from FRidh as a code owner June 19, 2019 06:51
matthiasbeyer
matthiasbeyer requested changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me beside the one little annotation.

pkgs/development/python-modules/django-crispy-forms/default.nix Show resolved Hide resolved
@risicle risicle mentioned this pull request Jun 19, 2019
Closed
10 tasks
@aakropotkin
Copy link
Contributor Author

Merging multiple PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aakropotkin @matthiasbeyer