Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitkraken: 5.0.4 -> 6.0.0 #63550

Merged
merged 2 commits into from Jul 10, 2019
Merged

gitkraken: 5.0.4 -> 6.0.0 #63550

merged 2 commits into from Jul 10, 2019

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Jun 20, 2019

Motivation for this change
  • A new major release for GitKraken is now available
Things done
  • Bump GitKraken to 6.0.0
  • Add new dependency on libuuid (libuuid.so.1)
  • Add new dependency on at_spi2_atk (libatk-bridge-2.0.so.0)
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Closure size is slightly larger now

$ nix path-info -S /nix/store/b566xa8w0apraw2v826jd6c9sv3h2kxi-gitkraken-5.0.4
/nix/store/b566xa8w0apraw2v826jd6c9sv3h2kxi-gitkraken-5.0.4       706752728

$ nix path-info -S /nix/store/56j0aq1wqf86sv21jr4xhmsxrr1wha8a-gitkraken-6.0.0
/nix/store/56j0aq1wqf86sv21jr4xhmsxrr1wha8a-gitkraken-6.0.0       929702928

evanjs and others added 2 commits June 19, 2019 23:55
@evanjs
gitkraken: 5.0.4 -> 6.0.0
4e08e8e 
- Add at_spi2_atk dependency
- Add libuuid dependency
@evanjs
Use at-spi2-atk instead of at_spi2_atk
6b799f2
@nlewo
Copy link
Member

nlewo commented Jun 25, 2019

@GrahamcOfBorg build gitkraken

megheaiulian
megheaiulian approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@megheaiulian megheaiulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and works nicely!

@nlewo
Copy link
Member

nlewo commented Jul 10, 2019

Thx for reviews and tests!

@nlewo nlewo merged commit 46d88d6 into NixOS:master Jul 10, 2019
@evanjs evanjs deleted the feature/gitkraken-6.0.0 branch July 19, 2019 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megheaiulian megheaiulian megheaiulian approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@evanjs @nlewo @megheaiulian @Janik-Haag