Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.buildbot-plugins: update hashes #63483

Closed
wants to merge 1 commit into from
Closed

pythonPackages.buildbot-plugins: update hashes #63483

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Noticed they were broken while doing nix-review of another package.

Added a note to the default.nix to update the hashes when changing the version number.

plugins in question:

buildbot-console-view
buildbot-grid-view
buildbot-waterfall-view
buildbot-wsgi-dashboards
buildbot_www
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner June 18, 2019 23:32
@FRidh
Copy link
Member

FRidh commented Jun 19, 2019

@jonringer you may want to get yourself added to the known users in NixOS/ofborg so it will always build your changes.
https://github.com/NixOS/ofborg#trusted-users-vs-known-users

@jonringer
Copy link
Contributor Author

jonringer commented Jun 19, 2019 •
edited

@FRidh PR located here :) NixOS/ofborg#371

EDIT: forgot github automatically cross-references links from other repos. Oh well :)

This was referenced Jun 21, 2019
Closed
Merged
@jonringer
Copy link
Contributor Author

I guess this is now a duplicate of #63644 (even though i was first 😢 lol)

Closing

@jonringer jonringer closed this Jul 3, 2019
@jonringer jonringer deleted the bump_buildbot_plugins branch July 9, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh