Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caddy: 0.11.4 -> 1.0.0 #63485

Merged
merged 2 commits into from Jun 20, 2019
Merged

caddy: 0.11.4 -> 1.0.0 #63485

merged 2 commits into from Jun 20, 2019

Conversation

allowthere
Copy link
Contributor

Motivation for this change

Caddy upgraded to 1.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ X ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [ X ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested using nixos-rebuild build-vm (ran caddy, it starts).

Issues:

  1. caddy -version returns unknown.
  2. -env flag was renamed to -envfile.

@allowthere
Copy link
Contributor Author

I think I fixed what broke the build. styx's server starts, but I don't have enough knowledge if anything else broke in the process.

@allowthere
Copy link
Contributor Author

allowthere commented Jun 20, 2019 •
edited

Should I ping the maintainers of caddy and styx?

@allowthere allowthere closed this Jun 20, 2019
@allowthere allowthere reopened this Jun 20, 2019
@allowthere
Copy link
Contributor Author

Sorry. Pressed the close button my mistake

@zimbatm
Copy link
Member

zimbatm commented Jun 20, 2019

Looks good to me

@zimbatm zimbatm merged commit 10f2815 into NixOS:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushmorem rushmorem Awaiting requested review from rushmorem

@zimbatm zimbatm Awaiting requested review from zimbatm

@fpletz fpletz Awaiting requested review from fpletz

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@allowthere @zimbatm @sjmackenzie