Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keybase: add git-remote-keybase to build #63554

Closed
wants to merge 1 commit into from
Closed

keybase: add git-remote-keybase to build #63554

wants to merge 1 commit into from

Conversation

jacobgreenleaf
Copy link
Contributor

Motivation for this change

The base package of keybase provides just the keybase binary. Keybase also provides a git remote helper binary under go/kbfs/kbfsgit/git-remote-keybase that allows users to clone encrypted repositories using the keybase://... scheme.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
$ nix-build -A keybase
$ /nix/store/wzbhqizqizn6riink0nk6brlhfiys92z-keybase-4.0.0-bin/bin/git-remote-keybase
Usage:
  git-remote-keybase -version

To run against remote KBFS servers:
  git-remote-keybase     [-debug]
    [-bserver=host:port] [-mdserver=host:port]
    [-log-to-file] [-log-file=path/to/file] [-clean-bcache-cap=0] <remote> [keybase://<repo>]
[...snip...]
$ nix-env -f . -iA keybase
installing 'keybase-4.0.0'
building '/nix/store/bx1bwr3qb4fqvpbk3kmz7w0sx0hk4a6i-user-environment.drv'...
created 5 symlinks in user environment
$ git clone keybase://team/[snip]
Cloning into 'gatewayV2'...
Initializing Keybase... done.
Syncing with Keybase... done.
Counting: 1.79 MB... done.
Cryptographic cloning: (100.00%) 1.79/1.79 MB... done.

@jacobgreenleaf
keybase: add git-remote-keybase to build
faf1200 
The existing keybase Nix package only builds the keybase binary.
This change also builds the git-remote-keybase tool to allow using
the git remote helper for keybase to clone encrypted repositories.
@jacobgreenleaf jacobgreenleaf marked this pull request as ready for review June 20, 2019 05:41
@srhb
Copy link
Contributor

srhb commented Jun 25, 2019

It appears that this was already included in the kbfs package, which used to come from its own repo on GitHub, https://github.com/keybase/kbfs

This is now archived, and refers to the path that you're referencing here. I think it still sort-of belongs in kbfs, but that package needs updating (and testing) -- what do you think?

@jacobgreenleaf
Copy link
Contributor Author

Thanks @srhb, closed in favor of #64377

@jacobgreenleaf jacobgreenleaf deleted the jg-keybase-git branch July 7, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobgreenleaf @srhb @Janik-Haag