Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdfcpu: init at 0.1.25 #63552

Merged
merged 2 commits into from Jun 21, 2019
Merged

pdfcpu: init at 0.1.25 #63552

merged 2 commits into from Jun 21, 2019

Conversation

doronbehar
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip" - non depend upon it.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit June 20, 2019 05:34
kalbasit
kalbasit requested changes Jun 20, 2019
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title, and commit message for the package should be pdfcpu: init at 0.1.25

pkgs/applications/graphics/pdfcpu/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from kalbasit June 20, 2019 16:01
@doronbehar doronbehar changed the title Add Go package pdfcpu pdfcpu: init at 0.1.25 Jun 20, 2019
@ofborg ofborg bot requested a review from kalbasit June 20, 2019 19:37
@kalbasit
Copy link
Member

@GrahamcOfBorg build pdfcpu

@kalbasit kalbasit merged commit d3157cb into NixOS:master Jun 21, 2019
@doronbehar
Copy link
Contributor Author

Thanks!

@doronbehar doronbehar mentioned this pull request Jul 14, 2019
Closed
@doronbehar doronbehar deleted the package-pdfcpu branch August 22, 2019 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @kalbasit