Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.uproot: 3.4.19 -> 3.7.0 #63490

Merged
merged 4 commits into from Jun 19, 2019
Merged

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jun 19, 2019

Motivation for this change

Noticed it was broken when doing a nix-review of another package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

$ nix path-info -Sh ./result
/nix/store/7cvvcs0j7xh10w2aq1a4852p5yzf25vg-python3.7-uproot-3.7.0 155.5M

@jonringer jonringer requested a review from FRidh as a code owner June 19, 2019 00:31
@jonringer jonringer changed the title Bump uproot pythonPackages.uproot: 3.4.19 -> 3.7.0 Jun 19, 2019
@veprbl
Copy link
Member

veprbl commented Jun 19, 2019

@GrahamcOfBorg build python2Packages.uproot python3Packages.uproot

@veprbl
Copy link
Member

veprbl commented Jun 19, 2019

@GrahamcOfBorg build python2Packages.uproot python3Packages.uproot

@veprbl veprbl merged commit 7cb82ca into NixOS:master Jun 19, 2019
@veprbl
Copy link
Member

veprbl commented Jun 19, 2019

@jonringer Thank you!

@jonringer
Copy link
Contributor Author

Thanks for fixing the python2 build :) @veprbl

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/non-mandatory-test-with-pytest/3273/5

@jonringer jonringer deleted the bump_uproot branch July 9, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants