New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
octopus: init 0.6.3-beta #63488
octopus: init 0.6.3-beta #63488
Conversation
meta = with stdenv.lib; { | ||
description = "Bayesian haplotype-based mutation calling."; | ||
license = licenses.mit; | ||
homepage = https://github.com/luntergroup/octopus; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider using quotes.
{stdenv, fetchFromGitHub, cmake, boost, gmp, htslib, zlib, lzma, pkg-config}: | ||
|
||
stdenv.mkDerivation rec { | ||
name = "octopus-${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider using ${pname}
too.
''; | ||
|
||
meta = with stdenv.lib; { | ||
description = "Bayesian haplotype-based mutation calling."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No period here please.
Thanks for the feedback, I have amended the PR to address the issues raised. |
Motivation for this change
Initial expression for the Octopus variant caller.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)