vscodium: Symlink backwards-compabible vscodium executable
#63522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we make it so if either |
Synthetica9
force-pushed
the
vscodium-symlink
branch
from
4ee7fa3
to
dda2f50
Compare
I'm not sure I understand what you mean. |
eadwu
reviewed
Jun 19, 2019
Synthetica9
force-pushed
the
vscodium-symlink
branch
from
dda2f50
to
693480a
Compare
Mic92
reviewed
Jun 23, 2019
| @@ -33,6 +33,11 @@ in | |||
|
|
|||
| sourceRoot = "."; | |||
|
|
|||
| postInstall = '' | |||
| # Install legacy support: | |||
| ln -s $out/bin/${executableName} $out/bin/vscodium | |||
There was a problem hiding this comment.
Could you explain why we need a backwards-compatible symlink? Do upstream or other linux distributions provide such a symlink?
| @@ -69,6 +70,8 @@ in | |||
|
|
|||
| installPhase = | |||
| if system == "x86_64-darwin" then '' | |||
| runHook preInstall | |||
|
|
|||
| mkdir -p $out/lib/vscode $out/bin | |||
| cp -r ./* $out/lib/vscode | |||
| ln -s $out/lib/vscode/Contents/Resources/app/bin/${executableName} $out/bin | |||
There was a problem hiding this comment.
Suggested change
| ln -s $out/lib/vscode/Contents/Resources/app/bin/${executableName} $out/bin | |
| ln -s $out/lib/vscode/Contents/Resources/app/bin/${executableName} $out/bin | |
| runHook postInstall |
There was a problem hiding this comment.
You'll need preInstall after the else too.
|
I'm not sure this would be relevant to users anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)